Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include OpenMP shared libraries #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Include OpenMP shared libraries #339

wants to merge 1 commit into from

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Jun 12, 2024

Include the OpenMP shared libraries that are needed if you compile with -fopenmp or OpenMP target offload enabled.

rrbutani
rrbutani approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@rrbutani rrbutani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

If it isn't too much trouble would you mind adding a test for this? (cc_binary with -fopenmp that fails to build if these .sos aren't made available)

@jsharpe
Copy link
Member Author

jsharpe commented Jun 13, 2024

Sure, I'll look to putting a test together for this. IIRC where we use this may also need the addition of a -B flag to properly find the bundler executables from the toolchain (we currently set this via .bazelrc) but this test will highlight whether this is required for a general case.

thomasbaekkegaard
thomasbaekkegaard reviewed Oct 25, 2024
View reviewed changes
Copy link

@thomasbaekkegaard thomasbaekkegaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: lib/*omp* -files are not included in LLVM-19.* distributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasbaekkegaard thomasbaekkegaard thomasbaekkegaard left review comments

@rrbutani rrbutani rrbutani approved these changes

@fmeum fmeum Awaiting requested review from fmeum fmeum is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsharpe @rrbutani @thomasbaekkegaard